[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] #870: SRFI-13's string comparison procedur
|
From: |
Mario Domenech Goulart |
|
Subject: |
Re: [Chicken-hackers] [PATCH] #870: SRFI-13's string comparison procedures return integers |
|
Date: |
Wed, 20 Jun 2012 10:07:32 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) |
On Wed, 20 Jun 2012 09:11:23 +0200 Peter Bex <address@hidden> wrote:
> On Tue, Jun 19, 2012 at 07:09:25PM -0500, Jim Ursetto wrote:
>> Attached patch fixes ticket #870.
>
> Shouldn't there be regression tests for this? I know mario created
> a repo with tests for srfi-13 and srfi-1. Personally I think this
> really belongs in core, so why not do that now?
Regardless of the [in]existence of in-core tests for SRFI-13, I think
the patch is ok and actually improves things by fixing some bugs. I'd
like to push it. Any objection?
Best wishes.
Mario
--
http://parenteses.org/mario