chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix for exactness check and enforcing type


From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] Fix for exactness check and enforcing types in max/min (#887)
Date: Tue, 24 Jul 2012 11:18:16 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

* Peter Bex <address@hidden> [120718 21:23]:
> Hi all,
>
> Attached is a fix for #887.  I also noticed that (max 'x) => x,
> which means the #:enforcing in types.db is untrue, so I've also
> added a check of the first value's type in the max/min procedures.
> The other values (in "ns") are checked by the predicate.  Actually,
> the first value's type is checked twice now if the list is nonempty.
> If that's a huge deal we could change this, but it would complicate
> the code more and the differentiation will make the code more
> complicated and probably slow it down just as much as the extra check.

Thank you Peter, I have pushed this patch.

--
9 out of 10 voices in my head say, that I am crazy,
one is humming.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]