[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Chicken-hackers] [PATCH] Update irregex to 0.9.2 and update types.db en
From: |
Peter Bex |
Subject: |
[Chicken-hackers] [PATCH] Update irregex to 0.9.2 and update types.db entries |
Date: |
Fri, 30 Nov 2012 00:14:32 +0100 |
User-agent: |
Mutt/1.4.2.3i |
Hi all,
Attached is the latest fix by Alex for ticket #686, which will solve it
completely, bringing us in synch with upstream irregex 0.9.2.
I've also had a closer look at the types.db entries and corrected a few
mistakes and filled in some of the gaps where no specific types or
specialization was given.
I wasn't sure what to do with some of these, so I didn't mark
procedures which accept user-supplied procedures (for example,
irregex/fold, irregex-replace and a few others) as #:clean since
the user procedures might modify local state. I'm not sure if that's
correct or not. If not, these might be updated to be marked clean too.
Beware of bugs: looking over types.db made my head spin and I kept
second-guessing myself. It's picky and tricky stuff to map the correct
types to procedures, so I'm likely to have gotten at least a few things
wrong! I did test it against the irregex test suite (compiled with -O3)
and svnwiki-sxml (modified its .setup file to do the same) and this
caught a few small mistakes.
The cool thing is that the test suite immediately showed some assumptions
that are being tested; at several places the code just assumes a
matchresult object is returned (most matching procedures may also
return #f on nonmatch). This isn't wrong for the testsuite, but it user
code this would be a mistake, so this already shows promise for catching
some usage bugs in the next Salmonella run ;)
Cheers,
Peter
--
http://sjamaan.ath.cx
--
"The process of preparing programs for a digital computer
is especially attractive, not only because it can be economically
and scientifically rewarding, but also because it can be an aesthetic
experience much like composing poetry or music."
-- Donald Knuth
0001-Irregex-Fixing-folds-on-conditional-begin-patterns-w.patch
Description: Text document
0002-Finetune-types.db-entries-for-irregex-and-update-its.patch
Description: Text document
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Chicken-hackers] [PATCH] Update irregex to 0.9.2 and update types.db entries,
Peter Bex <=