[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] file=? function to compare two files
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] file=? function to compare two files |
Date: |
Fri, 25 Jan 2013 19:17:45 +0100 |
User-agent: |
Mutt/1.4.2.3i |
On Fri, Jan 25, 2013 at 07:15:44PM +0100, Peter Bex wrote:
> Finally, I only glanced over the code so please excuse me if I overlooked
> it, but AFAICT you don't check whether the file sizes are the same.
> If they're different, you can do an early return because two differently-
> sized files can't possibly be equal.
Never mind, I just notice that's exactly what you do first.
Mental note: Don't mail on friday evening just after a busy day at work!
Cheers,
Peter
--
http://sjamaan.ath.cx