[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] warn if var is bound multiple times in the
|
From: |
Felix |
|
Subject: |
Re: [Chicken-hackers] [PATCH] warn if var is bound multiple times in the same binding form |
|
Date: |
Tue, 05 Feb 2013 23:02:03 +0100 (CET) |
From: Peter Bex <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH] warn if var is bound multiple times in
the same binding form
Date: Mon, 4 Feb 2013 21:53:32 +0100
> On Sun, Feb 03, 2013 at 11:33:09PM +0100, Felix wrote:
>> From: Peter Bex <address@hidden>
>> >
>> > Could you please generate a fresh patch against master?
>>
>> Attached.
>
> How about this slightly improved version?
>
> The patch you posted warns multiple times per symbol seen. Usually this
> shouldn't be an issue, but consider a macro that erroneously generates
> the same identifier many times.
>
> Since it's the same name, it doesn't make much sense to warn more than
> once. The warning already says it's bound "multiple times".
This is of course much better. Pushed.
cheers,
felix