[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix for poll() "special" values in revent
|
From: |
Mario Domenech Goulart |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Fix for poll() "special" values in revent |
|
Date: |
Tue, 26 Feb 2013 13:16:36 -0500 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Hi,
On Tue, 26 Feb 2013 19:02:26 +0100 Peter Bex <address@hidden> wrote:
> Here's a patch to deal with "special" situations in poll(). Mario found a
> problem on Linux:
> http://paste.call-cc.org/paste?id=c01e9dfcce2f56e88be143a01c6c4fb0bf1bec25
> I think this is due to the change described here:
> http://lkml.indiana.edu/hypermail/linux/kernel/0103.1/0711.html
>
> In any case, we don't check poll() revents for any other values than
> POLLIN/POLLOUT, which is clearly wrong; if a pipe is closed, there's
> nothing to read, but it will be POLLHUP'ed. Apparently on non-Linux
> this generally won't be signalled like this (except maybe in some
> situations), which is why this wasn't noticed before.
Thanks a lot for fixing that, Peter. I've pushed your patch.
> I nominate this patch for inclusion in the stability branch.
add1.
It's not clear to me if I should wait for Jim to aprove this patch for
stability or if I should go ahead and push it myself.
Best wishes.
Mario
--
http://parenteses.org/mario