chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 1/2] write: escape DEL character in strings


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 1/2] write: escape DEL character in strings
Date: Tue, 5 Mar 2013 20:32:26 +0100
User-agent: Mutt/1.4.2.3i

On Tue, Mar 05, 2013 at 06:48:44PM +0100, Florian Zumbiehl wrote:
> Encode DEL (ASCII character 127) in strings as \x7f instead of as literal DEL
> in write.

Thanks for this (and the other) patch!  Here's a signed-off version,
which other team members may push.  I also nominate this patch for
inclusion in the stability branch.

I've changed write to output \a for BEL as well, so that strings are
output as compactly as possible.

I've reformatted and reflowed the PP code so it doesn't go as far beyond
column 80 anymore.  I've also fixed the output of #\alarm to be \a
(in your patch \b, but that's backspace, which I've also added).

I've also added a basic test for these escaped characters to pp-test.scm
BTW: Can anyone tell me why there's (test "\\" "\\") as the final line
in that file?  It should always pass, and has nothing to do with writing.

Cheers,
Peter
-- 
http://www.more-magic.net

Attachment: 0001-write-escape-DEL-character-in-strings-encode-BEL-as-.patch
Description: Text document

Attachment: 0002-extras-pretty-print-escape-control-characters-in-str.patch
Description: Text document

Attachment: 0003-Document-changes-in-pp-and-write-behavior.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]