chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.
Date: Fri, 15 Mar 2013 10:01:42 +0100
User-agent: Mutt/1.4.2.3i

On Fri, Mar 15, 2013 at 09:36:01AM +0100, Christian Kellermann wrote:
> * Florian Zumbiehl <address@hidden> [130315 07:58]:
> > Remove ##sys#expand-home-path as shell expansion has no place in a 
> > filesystem
> > API.
> 
> I'd rather prefer a "no-shell-expansion" feature than breaking the
> current behaviour. This way programmers can choose when they need
> a "dumb" implementation (because the name is made up by user input)
> or whether the old behaviour should work for them.

A saner way of doing it is to have an explicit shell expansion procedure
through which you can pass the path string.  That way, we achieve clean
separation of functionality.

> Ripping it out like this is not an option.

I agree we can't immediately do it, but we should strive towards a clean,
safe API in the long run.  Just keeping it around is not an option either.
Adding more parameters or options is ugly, IMHO.

Cheers,
Peter
-- 
http://www.more-magic.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]