Re: [Chicken-hackers] [PATCH] ##sys#read: don't drop first character of octal escape in error msg

[Florian Zumbiehl]

Hi,

> Attached is a slightly simplified patch (use the 'c' variable everywhere,
> instead of repeating the character from the case).

good idea indeed :-)

> Florian, I'd really appreciate it if you could attach your patches
> instead of putting them inline in your mail.  Your patches are the
> only ones that are different, breaking the standard workflow I use
> when dealing with patches from chicken-core.

Would what git format-patch's --attach produces help you? Not sure whether
that actually would work with my workflow, but I could try it ...

I really don't intend to make life difficult for you, but it's just so
convenient to have git format-patch produce a bunch of files and then call
mutt -H on them, optionally add some non-commit-message comment, and send
it, with automatic threading and all, much less hassle than putting each
mail together manually from multiple pieces, and much less risk of screwing
things up as well.

Plus, the mails are exactly the format you seem to expect as an attachment,
so I would expect you should be able to just feed the whole mail into your
process instead of just the attachment? Presumably, you are using git am?
That's at least roughly how patch transport over mail was intended to work
with git--at one end, you have git produce the mails, at the other end, you
have git import the mails into some branch.

Also, apart from the compatibility of our two processes: IMO it's good and
useful that the diff format is a plain text format and one should take
advantage of it. The diffs really are an important part of the message that
should be easy to quote and comment on. And that should be readily
accessible when reading the mail, which applies even more so for the commit
message. Attaching patches to patch mails strikes me a bit like attaching
word documents to otherwise almost empty "letter emails".

Regards, Florian