chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 3/4] Remove ##sys#expand-home-path.
Date: Tue, 19 Mar 2013 16:44:24 +0100
User-agent: Mutt/1.4.2.3i

On Fri, Mar 15, 2013 at 07:58:02AM +0100, Florian Zumbiehl wrote:
> Remove ##sys#expand-home-path as shell expansion has no place in a filesystem
> API.

I've moved the ~ behaviour to a new procedure in "utils" called "ep" and
updated the NEWS file and docs.

The signed off patch is attached.

I'm not 100% sure how to handle this, as it's a backwards-incompatible
change.  Pushing it as-is could possibly cause breakage in existing
programs, but it will also fix programs that don't knowingly rely on
this behaviour.

BTW: This behaviour isn't really compatible with the shell's, since it
disallows strings formatted like ~username from being expanded to that
user's homedir.  The shell would expand ~ to the current user's homedir
only in a string where it's immediately succeeded by a slash, like ~/foo.
This will now expand to the current user's homedir with foo pasted at
the end, like "/home/peterfoo".  I don't know if this is a bug or
intended behaviour, so I kept it the way it was before.

Cheers,
Peter
-- 
http://www.more-magic.net

Attachment: 0001-Remove-sys-expand-home-path.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]