Re: [Chicken-hackers] [PATCH] fix incorrect type of jmp_buf

[Jörg F . Wittenberger]

On Jun 18 2013, Peter Bex wrote:

> On Tue, Jun 18, 2013 at 02:04:32PM +0200, Jörg F. Wittenberger wrote:
> > On Jun 18 2013, Jim Ursetto wrote:
> >
> > >On Jun 17, 2013, at 2:06 AM, Felix 
> > ><address@hidden> wrote:
> > >>
> > >>This is quite a serious bug, and I recommend putting the patch into
> > >>the stability branch.
> >
> > Congratulations to this catch!
> >
> > While I'm not sure that this was really the reason, I can't see any 
> > other. I had long standing problems with threads dropped from the 
> > waiting queue at random. Couldn't find the reason. Since yesterdays 
> > update the problem appears gone with no other code changes.
>
> Great to hear!
>
> I know you've used Valgrind on CHICKEN in the past.  Does it not detect
> this problem, or have you not tried it recently?

At least I tried not recently, certainly not since the sig*jmp stuff
came in.

Also running my code under valgrind doesn't *really* work.  It did
catch some uninitalized variables etc (one "count" is still not fixed in
C_reclaim:


   if(gc_mode == GC_REALLOC) {
     C_rereclaim2(percentage(heap_size, C_heap_growth), 0);
     gc_mode = GC_MAJOR;
     count = (C_uword)tospace_top - (C_uword)tospace_start;
     goto i_like_spaghetti;
   }

The "count" above.

But the result runs way too slow to work in concert within the
timeout limits of the whole network.

Also those thread drops where really random to be.  Rarely within
minutes after program start, sometimes only after hours.  I would
not even have the disk space to log this, let alone patience.


> Maybe we could start using Valgrind in the Salmonella runs.. Not sure if
> that would skew the test results, though...
>
> Cheers,
> Peter