Re: [Chicken-hackers] [PATCH] dynamic trace buffer resizing

[Jim Ursetto]

On Aug 12, 2013, at 3:13 PM, Peter Bex <address@hidden> wrote:

> On Mon, Aug 12, 2013 at 03:10:59PM -0500, Jim Ursetto wrote:
>> On Aug 12, 2013, at 2:11 PM, Peter Bex <address@hidden> wrote:
>>>> Looks useful.  Could it perhaps be more useful to make the argument
>>>> to C_resize_trace_buffer a regular size_t instead of a Scheme fixnum?
>>>> That might make it slightly more usable from an embedded situation.
>> 
> 
> The other limits annoy me equally ;)  So I guess it's probably enough to
> have a minimum, or even rip that out as well (minimum of 0 = no history),
> but I'm afraid that'd be more difficult.
> 
>> Actually, I just realized the arg isn't checked to be a fixnum.  I'll change 
>> that when I incorporate any suggestions.

Attached is new patch without max limit and with exact arg check.  Going to 
defer the size_t change to a later patch because numerous places expect it to 
be int, and it has to be changed everywhere correctly.

Aside: this is currently in the ##sys namespace to avoid making it an official 
interface for now, in case e.g. people want the user interface to be a 
parameter.

0001-Make-trace-buffer-resizable-at-runtime-via-sys-resiz.patch
Description: Binary data