[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix #1041 by checking buffer size when not
|
From: |
Peter Bex |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Fix #1041 by checking buffer size when not supplied |
|
Date: |
Tue, 24 Sep 2013 09:12:02 +0200 |
|
User-agent: |
Mutt/1.4.2.3i |
On Mon, Sep 23, 2013 at 11:10:22PM +0000, Mario Domenech Goulart wrote:
> Thanks a lot, Peter.
>
> Unfortunately, it seems that it doesn't fix #1045. I still can
> reproduce the crashes with awful-picman.
Yeah, I was afraid it wouldn't fix that bit.
> Your patch fixes a bug, so I think it should be pushed. I'm attaching
> an edited version with a slight modification to avoid calling
> (##sys#size dest) twice in certain code paths (as we discussed on IRC).
> I also edited the commit message to remove the "Fix #1045" part.
Excellent.
> I haven't pushed it because I edited it. The edited version is signed
> off, so feel free to push it if you agree with the changes.
Good job, thank you Mario. I've pushed it almost as-is (I made a mistake
in the NEWS entry; it should be below 4.8.3, not 4.8.2)
Cheers,
Peter
--
http://www.more-magic.net