[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix file-creation-mode
From: |
Christian Kellermann |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix file-creation-mode |
Date: |
Wed, 2 Oct 2013 14:15:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Peter Bex <address@hidden> [131001 22:29]:
> Hi all,
>
> Here's another strange little bug found by the assertion patch.
> I don't understand why (file-creation-mode) correctly returns the
> old value, because the parens are mismatched.
>
> This patch fixes that and ensures that #f is never passed to C_unfix,
> which is why the paranoid CHICKEN caused the panic. I've also updated
> the documentation so it mentions the fact that file-creation-mode's
> argument is optional.
Excellent findings! I have pushed this. As for the patch that found
this, it is too hairy to me, so I want to wait for a salmonella run
on the other one.
Thanks!
Christian
--
In the world, there is nothing more submissive and weak than
water. Yet for attacking that which is hard and strong, nothing can
surpass it. --- Lao Tzu