[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix list->queue data corruption issue

From: John Cowan
Subject: Re: [Chicken-hackers] [PATCH] Fix list->queue data corruption issue
Date: Wed, 2 Oct 2013 20:11:58 -0400
User-agent: Mutt/1.5.20 (2009-06-14)

Peter Bex scripsit:

> When run with paranoid CHICKEN, it tells us nicely where it's going
> wrong: the list->queue procedure uses the low-level structure constructor
> ##sys#make-structure with 3 arguments: the structure type, the list and
> the list tail.  Unfortunately, make-queue calls ##sys#make-structure
> with 4 arguments: the structure type, the list, the list tail and the
> queue's length.  

Insert rant here about the use of unsafe procedures from Scheme code
for the sake of tiny and probably imaginary efficiency improvements.
We SHOULD NOT do this.  Indeed, it would be a Good Thing to have
some code that checks for calls on unsafe procedures and reports them
unless a comment is present saying that someone has verified that
this unsafe call is required.

It was dreary and wearisome.  Cold clammy winter still held sway in this
forsaken country.  The only green was the scum of livid weed on the dark
greasy surfaces of the sullen waters.  Dead grasses and rotting reeds loomed
up in the mists like ragged shadows of long-forgotten summers.
        --"The Passage of the Marshes"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]