[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Build/Test CHICKEN on AIX

From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Build/Test CHICKEN on AIX
Date: Mon, 28 Oct 2013 10:27:45 +0100
User-agent: Mutt/

On Sun, Oct 27, 2013 at 12:22:22PM +0000, Mario Domenech Goulart wrote:
> On Sat, 26 Oct 2013 22:31:51 -0600 Erik Falor <address@hidden> wrote:
> Awesome job, Erik.  Thanks a lot.

+1, this is excellent work!

> I tested your patch on Linux x86-64
> and it doesn't seem to affect that platform (as expected).

I've just done a quick check on NetBSD/amd64 (with clang), and
everything's still fine here too.

> I'm totally for integrating your work into the official repo.  Even if
> not all CHICKEN features work, it seems to me that we have a pretty
> decent tool to work with on AIX (unless salmonella discovers some
> critical problem).
> With regard to deployment tests, I think it would be nice to modify that
> conditional to print something indicating that deployment tests are not
> supported on AIX.  Something like:
> if test $OS_NAME = AIX; then
>     echo "Disabling deployment tests, as they are not supported on AIX."
> else
>     # tests here
> fi
> Here are some additional things we should do to get support for AIX
> properly integrated into CHICKEN:
> * update NEWS
> * update README, section 5 (Platform Issues).  We should add a note
>   stating that deployment is not supported on AIX
> * update manual/Deployment: add a note stating that deployment is not
>   supported on AIX

* add the Makefile to the distribution/manifest file


I've done all these things you mentioned above, and signed off this
patch.  As per our development process, one more CHICKEN Team member
needs to sign off on my version before it can be pushed.

I think adding support for AIX is a Good Thing.

> Finally, none of the current maintainers have access to AIX systems, so
> we cannot test CHICKEN on it.  Thus, testing CHICKEN on AIX will totally
> rely on users who have access to AIX systems.

Yes, just like Haiku, Solaris and Windows :)


Attachment: 0001-Add-support-for-AIX.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]