[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix unsetenv on Windows
|
From: |
Mario Domenech Goulart |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Fix unsetenv on Windows |
|
Date: |
Sat, 09 Nov 2013 16:01:25 +0000 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
On Sat, 9 Nov 2013 16:49:44 +0100 Peter Bex <address@hidden> wrote:
> On Sat, Nov 09, 2013 at 03:44:03PM +0000, Mario Domenech Goulart wrote:
>> On Sat, 9 Nov 2013 16:30:35 +0100 Peter Bex <address@hidden> wrote:
>> > On Sat, Nov 09, 2013 at 03:26:21PM +0000, Mario Domenech Goulart wrote:
>> >>
>> >> Environment variables were not really being unset on Windows.
>> >
>> > Why does the patch use setenv() with an empty string, instead of
>> > unsetenv()? Doesn't Windows support that?
>>
>> It seems that Windows doesn't support unsetenv:
>>
>> posixwin.o: In function `f_4452':
>> c:\src\chicken-core/posixwin.c:7400: undefined reference to `unsetenv'
>
> OK, thanks, I've pushed this. I've also added a small note in the
> sources, because that was nonobvious to me :)
Good point. Thanks.
> Should this one go into stability? I'm inclined to say "yes".
I forgot to mention that. I also think it should go to stability.
Best wishes.
Mario
--
http://parenteses.org/mario