[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix various Haiku issues
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix various Haiku issues |
Date: |
Sun, 10 Nov 2013 22:19:26 +0100 |
User-agent: |
Mutt/1.4.2.3i |
On Sun, Nov 10, 2013 at 09:14:28PM +0000, Mario Domenech Goulart wrote:
> I think it would be better to split this patch into a patch per change,
> so we can properly bisect and easily revert changes if needed. "git add -p"
> can be handy at splitting it.
Feel free to split it up.
> I couldn't find the code related to the "The unsetenv() test failed. It
> was using putenv() but Haiku is a (mostly) GNU system so unsetenv() is
> available" note in the commit message.
This change is the bit where I added defined(__HAIKU__) to the condition
around # define C_GNU_ENV, which controls (among other things) whether
putenv() is used or getenv() should be used.
Ideally, we'd get rid of all these weird conditionals and move to a
more feature-based check. However, I didn't want to make the change
too big: we're moving towards a release and I want this to go into
the stability branch, so it should not possibly cause any breakage
for other platforms.
Cheers,
Peter
--
http://www.more-magic.net