chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Simplify header file inclusion


From: Kon Lovett
Subject: Re: [Chicken-hackers] [PATCH] Simplify header file inclusion
Date: Mon, 25 Nov 2013 12:02:00 -0800

On Nov 24, 2013, at 11:48 AM, Peter Bex <address@hidden> wrote:

> Hi all,
> 
> Initially I wanted to keep this patch until after 4.9.0 was released,
> but I figured what the hell, we'll need to go through a release
> candidate cycle anyway and this patch isn't *that* risky, but it
> cleans up things considerably (should also lower build times somewhat).
> 
> The patch simply rearranges some header files and simplifies
> several .scm files as many headers are unnecessary since they
> they already are included by chicken.h.  I also got rid of several
> messy preprocessor conditionals.  All of them are well-reasoned out,
> as indicated by the commit message (which may be a bit terse, so if
> you want me to expand upon it, just ask here).
> 
> Basically this shuffles some stuff around, it doesn't change anything
> fundamentally.  I just took a hard look at what headers ended up being
> included unconditionally in some places, and removed all of the
> #ifdef-hedged instances of inclusion of the same header.
> 
> I've tested on Linux, NetBSD, Haiku, cygwin, mingw and mingw-msys.

Successfully built & ran "check" target on:

Version 4.8.3 (rev 6ca6044)
macosx-unix-clang-x86-64 [ 64bit manyargs dload ptables ]

Darwin kurashiki 12.5.0 Darwin Kernel Version 12.5.0: Sun Sep 29 13:33:47 PDT 
2013; root:xnu-2050.48.12~1/RELEASE_X86_64 x86_64

> 
> Cheers,
> Peter
> -- 
> http://www.more-magic.net
> <0001-Simplify-handling-of-header-file-inclusion.patch>_______________________________________________
> Chicken-hackers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/chicken-hackers




reply via email to

[Prev in Thread] Current Thread [Next in Thread]