Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

[Peter Bex]

On Thu, Nov 28, 2013 at 09:11:15PM +0100, Peter Bex wrote:
> On Fri, Nov 22, 2013 at 09:43:31PM +0100, Peter Bex wrote:
> > The error handling in Windows was completely broken; the errmap
> > loop updated map, but looked at errmap.
> 
> This whole error handling shit needs to get reworked to make the
> Windows error->errno conversion used everywhere.  Winsock2 only *looks*
> like the BSD sockets API, it uses the same function names but its error
> handling is completely different so it's not really compatible.
> 
> So my advice for now is NOT to apply these two patches yet, but rework
> them in a complete overhaul of Windows error handling.  That naturally
> means that the stability branch should NOT get any of these patches,
> because the changes will just be too invasive.

I was wrong: this can't be generalised.  Winsock errors are completely(?)
distinct from other errors.   Luckily this means that the process patch
can be applied as-is, without any changes and it can still go into
stability.

I'll post a new patch for tcp, hopefully soon.

Cheers,
Peter
-- 
http://www.more-magic.net