[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc
|
From: |
Peter Bex |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc and memq/memv/member |
|
Date: |
Mon, 27 Jan 2014 14:16:42 +0100 |
|
User-agent: |
Mutt/1.4.2.3i |
On Mon, Jan 27, 2014 at 01:06:48PM +0100, Moritz Heidkamp wrote:
> > You somehow missed C_i_memv, though, which resulted in library-tests
> > to fail. So at least the tests are complete :)
>
> Hm, that's weird, I was sure I had given it a final run. Anyway, I might
> be missing something but my patch actually does cover C_i_memv (lines
> 73-82), doesn't it? AFAICT you added another check to C_u_i_memq,
> referring to memv in the error message. But isn't the point of C_u_*
> variants to be unchecked?
I don't know, I seem to be losing my mind or something :)
> Note that I made a bootstrap build before running the tests. Maybe
> that's why the tests didn't fail for me?
I did a full rebuild using the new CHICKEN. The test failed because
it did not receive an error so that's unlikely to be due to old code.
Cheers,
Peter
--
http://www.more-magic.net