Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

[Peter Bex]

On Thu, Jun 12, 2014 at 09:56:50PM +0200, Peter Bex wrote:
> But, like I said, it will probably break a shitload of scripts and
> programs.  To remedy that we can let C_COMPILER / C_COMPILER_OPTIONS
> inherit from CC / CFLAGS by using "?=" judiciously:
> 
> ######################################################################################################
> # Optionally start with this:
> ifneq ($(origin C_COMPILER)$(origin C_COMPILER_OPTIONS),undefinedundefined)
> $(warning $$(C_COMPILER) and $$(C_COMPILER_OPTIONS) are obsolete; use $$(CC) 
> and $$(CFLAGS) instead)
> endif
> 
> C_COMPILER?=$(CC)
> C_COMPILER_OPTIONS?=$(CFLAGS)
> 
> # and keep, unchanged:
> TARGET_C_COMPILER ?= $(C_COMPILER)
> ######################################################################################################
> 
> This will allow us to gradually phase out C_COMPILER; we obsolete it
> first, then after 4.10.0, maybe change $(warning) to $(error) and
> finally remove it in 4.11.0.  This means it won't immediately break
> existing scripts or configs which override C_COMPILER.

I realised we can obsolete INCDIR and TOPMANDIR (and, to a lesser extent,
MANDIR) like this as well.

Attached is a modified version of my earlier patch with a deprecation
warning added.  If both TOPMANDIR and MANDIR are defined, I decided to
cause a hard error because of the ambiguity.  If only MANDIR is defined,
we strictly can't tell whether that's a "new style" MANDIR or an old one,
unfortunately.

Cheers,
Peter
-- 
http://www.more-magic.net

0001-Make-the-handling-of-variables-for-directory-prefixe.patch
Description: Text document