Re: [Chicken-hackers] [PATCH] Fix #819 by marking file-mkstemp as unimplemented on Windows

[Michele La Monaca]

On Sun, Aug 3, 2014 at 3:35 PM, Peter Bex <address@hidden> wrote:
> On Sun, Aug 03, 2014 at 03:20:50PM +0200, Michele La Monaca wrote:
>> Another twist. Basically the same patch but with a more robust path
>> manipulation strategy.
>
> Yeah, I was wondering why you were using string-append and friends
> to manipulate paths :)
>
> I don't understand why you treat the extension and directory specially.
> Neither the pathname separator nor the dot before the extension are
> an X, so scanning backwards in the template will automatically stop
> on those.

Right, maybe it's just too hot to write code here :)

> Anyway, see my other mail for a simplified and tested patch.

I can't try it but your changes looks good to me.

Regards,
Michele