[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH 2/2] Invert poll(2) flag default
From: |
Moritz Heidkamp |
Subject: |
Re: [Chicken-hackers] [PATCH 2/2] Invert poll(2) flag default |
Date: |
Wed, 20 Aug 2014 20:41:31 +0200 |
HI Peter,
Peter Bex <address@hidden> writes:
> This seems like a good idea. However, could you also swap the two
> code blocks? A double negation (#ifndef NO_...) can be confusing, and
> by making it read "#ifdef NO_POSIX_POLL" (I'd probably drop the
> HAVE_ prefix, as that's more idiomatic AFAICT), it becomes a little
> clearer.
you are right--my intention was to make the patch as non-invasive as
possible so its purpose is obvious. Now that the purpose should be
clear, find attached an updated version which swaps the code blocks to
avoid the double negation. I also dropped the HAVE_ prefix as per your
suggestion, I didn't see the other flags names like that. Thanks for the
hint!
Moritz
0001-Invert-poll-2-flag-default.patch
Description: Text Data