Re: [Chicken-hackers] [PATCH(5)] Teach Henrietta about major releases

[Mario Domenech Goulart]

Hi,

On Sun, 14 Sep 2014 15:32:24 +0200 Peter Bex <address@hidden> wrote:

> Here are a handful of patches to make CHICKEN 5 eggs installable:
>
> The henrietta.patch applies to Henrietta trunk, which lives in SVN.
> I decided to put it on this list for consideration, so we all know what's
> happening with the infrastructure, and after all it does apply to the
> new core developments.  It is just a proposal, but I think this patch
> will make things much easier further down the road.
>
> When trying to update CHICKEN and Henrietta so that chicken-install can
> pass the major CHICKEN release to Henrietta, I noticed that they are
> strangely intertwined: henrietta calls into the same API that
> chicken-install uses.  Basically henrietta uses the "local" transport
> which chicken-install would normally use on the server, but then serves
> up the results over HTTP to the chicken-install running on the client
> machine.  This is needlessly cyclic and complicated: it's simply reading
> a directory!
>
> The old henrietta used to be able to serve over svn too, but we don't
> use that anymore since the SYSTEM has gone live, so I think it's safe
> to simplify henrietta by copying all the "local transport" code from
> setup-download into, and removing the dependency on core.  This allows
> us to freely rewrite chicken-install (if we ever want to) without having
> to worry about whether it will break Henrietta.
>
> I've also removed the now-pointless "tags" subdirectory: this makes the
> directory layout somewhat flatter and simpler.  The cache would look
> like this:
> /var/www/henrietta-cache/4/easyffi/1.0
> /var/www/henrietta-cache/4/easyffi/2.0
> /var/www/henrietta-cache/4/spiffy/1.0
> /var/www/henrietta-cache/4/spiffy/1.1
> ...
> /var/www/henrietta-cache/5/spiffy/2.0
> /var/www/henrietta-cache/5/srfi-18/1.0
>
> This will require a small change in henrietta-cache as well, of course,
> so it won't try to include a "tags" directory in the path.
>
> Now, on to the core patches!
>
> The first core patch removes support for Subversion from setup-download.
> It is not needed at all and needlessly complicates things.  The special
> status of svn in our infrastructure is mostly gone, and if you want to
> install a particular egg from svn, it's not much of a hassle to make a
> checkout first.  Of course, this patch is optional; if you disagree feel
> free not to push it.
>
> The second core patch adds the "release" argument to the query string
> which the new version of Henrietta will parse.
>
> Once everything is pushed, I'll see to it that henrietta-cache gets
> updated and will set up the whole thing on the call-cc.org server
> together with Mario.  After a short testing period, I'll ping Alaric
> about updating his server, too.

Thanks for all the patches, Peter.  I'm for all of them (considering the
patch for setup-download in your follow-up message).

If nobody has objections, I'll push them.  I know our patch application
policy would allow me to just push your patches, but since these patches
introduce changes that are backward-incompatible and depend on changes
on eggs (henrietta), I'd like to wait to see if people have objections,
since there is at least one alternative that does not require CHICKEN or
egg changes (i.e., having a separate CGI script for henrietta + another
location in setup.defaults).

I'm for you proposal, since it seems to be the most easily "scalable" in
the long run (doesn't require a new CGI script + setup.defaults change
for each CHICKEN major version).

I'm also for removing svn support from the core, since it doesn't make
much sense now that the distributed egg system is in use.  If we remove
svn support, I'd suggest removing the -trunk option for
chicken-install.  I can do that, if people agree on removing it.

Once we have the multiple CHICKEN versions support sorted out, we can
start populating the release/5/egg-locations file and run some
salmonella instances for the chicken-5 branch.

Best wishes.
Mario
-- 
http://parenteses.org/mario