Re: [Chicken-hackers] [PATCH] Removed few usages of gcc extensions from runtime

[Peter Bex]

On Wed, Oct 22, 2014 at 12:36:35AM +0400, Oleg Kolosov wrote:
> Hello.
> 
> Here is another patch which is useful for MSVC support but not harmful anyway.

Hi there,

This patch looks like a sensible thing to do.  It's pretty
weird/unexpected to me that all of GCC, clang and SunW (and I think
pcc, too) even accept this!

Anyway, two notes:

- You used four spaces to indent the second level of indentation,
   but 2 spaces for the first level (which is standard in our code).
   I've fixed that to use 2 spaces everywhere.
- for (x; y; ) just "looks" wrong to me, like someone forgot to put
   an increment operation there.  It's more of a style thing, and
   it doesn't matter, and you can easily see that the increment happens
   on the next line, but it does require a little bit of extra attention.
   So I changed it to move the increment back into the for loop.  It is
   semantically exactly the same, and looks more balanced.  I used the
   pre-increment operator purely for consistency with the surrounding
   code.

Attached is a signed-off copy with the mentioned changes.

Thank you for the patch!

Cheers,
Peter
-- 
http://www.more-magic.net

0001-Removed-few-usages-of-gcc-extensions-from-runtime.patch
Description: Text document