[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 0/2] Fix #t being "not always-true"

From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 0/2] Fix #t being "not always-true"
Date: Mon, 25 May 2015 15:55:49 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, May 25, 2015 at 07:28:16AM +1200, Evan Hanson wrote:
> On 2015-05-24 16:23, Peter Bex wrote:
> > But your patch doesn't include the testcase I added in that mail.  Do
> > you believe the test is not useful, or wrong?
> Nope, just missed it. Here's the second patch with that addition,
> thanks for pointing that out.

Cool, thanks for clarifying.  I've pushed this, and also applied it
to the CHICKEN 5 branch.  This caused a conflict, because this branch
doesn't have the CHICKEN_COMPILER_OPTIONS anymore; it uses
CHICKEN_PROGRAM_OPTIONS throughout, for simplicity.  I've simply
removed -local from the CHICKEN_PROGRAM_OPTIONS, as I don't think
this will make much of a difference anyway; any performance bottlenecks
will not be in the programs themselves but in libchicken.

I've also added a small commit to silence a "always true" warning for
irregex, which was indeed correct.  However, because we try to deviate
from upstream as little as possible, it's better to silence the warning
than to remove the IF-conditions.


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]