[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] Add test suite and improve find-files performance
From: |
Mario Domenech Goulart |
Subject: |
Re: [Chicken-hackers] Add test suite and improve find-files performance |
Date: |
Fri, 12 Jun 2015 11:51:47 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
On Fri, 12 Jun 2015 17:05:39 +1200 Evan Hanson <address@hidden> wrote:
> Nice improvement, thanks.
>
> I've pushed this to both branches, along with a minor change to the new
> test suite that makes the comparisons between lists of filenames
> insensitive to ordering (without this change the tests would fail on my
> machines, since `find-files` might return results in a different order
> than the script expected).
Thanks, Evan.
With regard to results in a different order, I was wrongly [*] assuming
it'd always keep the same order for the same inputs. I wonder if the
unpredictable order will somehow break `delete-directory'. Anyway, the
old glob approach would also rely on the `directory' behavior, so the
lack of predictable order will not be a new issue.
[*] http://stackoverflow.com/questions/8977441/does-readdir-guarantee-an-order
Best wishes.
Mario
--
http://parenteses.org/mario