Re: [Chicken-hackers] proposed change to identify.sh

[Jörg F. Wittenberger]

No thoughts on this.  You are right.  I don't recall why it was written
this way.

Am 13.06.2015 um 14:53 schrieb Peter Bex:
> On Sat, Jun 13, 2015 at 02:19:10PM +0200, "Jörg F. Wittenberger" wrote:
>> When building chicken without git I never really succeed.  Hence I'm
>> using a modified identity.sh.
>>
>> Dunno what I'm doing wrong, but maybe this is more flexible.  It should
>> not change the way chicken compiles normally.
> 
> The patch looks good to me, and the use case makes sense.  Just one question
> though: Why does line 25 read:
> 
>     : ${branchname:="custom"}
> 
> I don't understand what the colon is doing exactly, and why you're using
> the ${...:=} syntax for branch but not for tag.
> 
> Maybe it should be changed to read as follows:
> 
>     branchname=${branchname:-custom}
>     tag=${tag:"#define C_BUILD_TAG \"compiled ${buildtime} on ${host} 
> (${usys})\""}
> 
> Thoughts?
> 
> Cheers,
> Peter
>

signature.asc
Description: OpenPGP digital signature