chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 1/2] Allow overriding of interpreter path f


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 1/2] Allow overriding of interpreter path for POSIX tests
Date: Sat, 1 Aug 2015 16:36:00 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Sat, Aug 01, 2015 at 05:26:00PM +0300, Oleg Kolosov wrote:
> I've added test suite to my work in progress CMake base build system which is 
> supposed to work with out of source builds. This will allow current and new 
> systems to coexist. This patch facilitates that.

Perhaps it makes more sense to define some sort of BUILD_DIR, which
gets passed from the Makefile (or whatever other build system is being
used).  It could default to "..".  This makes it easier to add tests
for other CHICKEN programs without exporting more and more shell
variables.

> While working on Windows support I've also found various small things like 
> more missing C_ prefixes, missing #ifdef HAVE_... around includes and such 
> and decided to submit them separately starting from the most trivial ones.
> 
> But looks like with large time interval between patches it is confusing. I 
> can submit everything at once when finish cleaning if it is easier to handle. 

I find it all rather tricky to handle as the CHICKEN 4 and 5 branches
have diverged further and further.  I'm not sure how many large-scale
changes we'll be able to accept for CHICKEN 4; all of those will have
to be integrated into CHICKEN 5 as well.

Cheers,
Peter

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]