chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH][5] Make temporary stack resizable (fixes #


From: felix . winkelmann
Subject: Re: [Chicken-hackers] [PATCH][5] Make temporary stack resizable (fixes #1098)
Date: Wed, 04 Nov 2015 10:17:26 +0100

> > Calling a function directly with 5000 arguments will "just work" in the
> > common case.  However, if this call happens to occur while the stack is
> > full, the assertion will be triggered.  Let's say this happens in
> > production but not in your development setup, then it would be pretty
> > hard to find this bug.
>
> And if your production code is embedded in a device, it's really bad.

That's exactly why I prefer a hard limit, where this would be caught by the 
argument count
check. Unfortunately, several issues are conflated here - the existing 
implementation,
dynamic resizing and a fixed hard limit, easily confusing the uninformed...


felix




reply via email to

[Prev in Thread] Current Thread [Next in Thread]