Re: [Chicken-hackers] [PATCH] Make character comparisons safe

[Peter Bex]

On Mon, Nov 30, 2015 at 11:03:42PM +1300, Evan Hanson wrote:
> Hi Peter,
> 
> This looks good, nice and straightforward. Pushed to both branches.

Thanks for that!

> Of course, now that I've noticed it, it's totally bugging me that we
> have `C_i_greater_or_equalp` on the one hand but
> `C_i_char_greater_or_equal_p` on the other, with different suffixes.
> Might have to fix that at some point or it'll drive me insane. But, I
> see that this patch inherited the names so we'll leave it alone for now.

This has been bothering me for ages :)  I think we should at some point
take the time to go through core and fix all these nagging
inconsistencies.  There are others, like some inline functions not
having _i_ in the name, some "p" suffix functions returning C "integer
booleans" and others returning Scheme booleans, and so on and so forth.

It's not important enough to fix soon, and it breaks things.  I'd say
do it in the chicken-5 branch, but we still have enough on our plates
for CHICKEN 5.  So maybe we'd have to delay it to CHICKEN 6, or figure
out some way to cleanly rename everything while keeping backwards
compatibility (but I'm afraid that would mean we need to switch to a
completely new naming scheme because of the inconsistencies).

Cheers,
Peter

signature.asc
Description: Digital signature