[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] A stupid but serviceable fix for #1110

From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] A stupid but serviceable fix for #1110
Date: Tue, 08 Dec 2015 14:02:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Peter Bex <address@hidden> writes:
> So here's another fix, this is an attempt to slightly improve the error
> message you get when Henrietta returns an error.  Henrietta is supposed
> to return an s-expression (error "blabla") when something doesn't work
> out well, but there's a mismatch between the code that tries to parse
> the first line henrietta outputs and the code that READs the s-expression
> it returns.
> Detecting (error ..) on the line is an ugly fix, I know and not 100%
> reliable, but it's slightly better than what we have now, and at least
> the code that's supposed to be triggered gets triggered now.  And we can
> close another ticket :)

I have pushed this for now, there seems to be a change in chicken-5's
version of setup-download.scm that's not in master:

--8<---------------cut here---------------start------------->8---
                ((irregex-match '(* ("\x09\x0a\x0b\x0c\x0d\x20\xa0")) ln)
                 (skip)) ; Blank line.
--8<---------------cut here---------------end--------------->8---

This has been introduced by commit,
0cf4eba9060bdd4354afe50cb6c4ef38146694e2 "Remove srfi-14"

Question is, what does it do and why is it there and should it be

Kind regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]