[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot

From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations
Date: Wed, 9 Dec 2015 08:59:17 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 08, 2015 at 10:35:35PM +0100, address@hidden wrote:
> > Now, if you look at the patch you'll see that it changes irregex-core.scm,
> > which means it creates a "fork" against that part of the code in upstream.
> > I don't see a way to declare the type from the "outside", in irregex.scm,
> > unless we also copy that code body as a macro, but that feels really ugly
> > and will cause some code duplication in the resulting C code.
> I suggest creating a wrapper macro for "assume" with an (empty) 
> cond-expand'ed default
> definition and send this to upstream. If this change has such an impact, then 
> other
> implementations might take advantage from type-declarations as well.

Hm, I hadn't considered that.  I'll have to look over the other Schemes
and how their type systems work, and give this some more thought.
Thanks for the suggestion!

So for now, please don't apply this patch; I might send a new one with
the upstream change, if any (otherwise I'll resend this one).


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]