[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix (restore?) specializations from types.
Re: [Chicken-hackers] [PATCH] Fix (restore?) specializations from types.db when compiling core itself
Sun, 20 Dec 2015 18:11:24 +1300
I've pushed the read-char and types.db fixes. They make sense and offer
a good speedup -- nice work!
Unfortunately the scrutinizer change is a bit hairier. One problem is
that it causes the "-emit-types-file" option to include system-defined
types (i.e. those that come from from types.db) in generated .types
files, whereas it should only include those for values defined in the
file under compilation. That file's entries are generated by walking the
analysis database, so I don't think we'll be able to avoid keeping track
of whether a given type came from the user or from a types file so that
we can determine whether to generate a type for it in this situation.
There's also now the problem of what to do when the user redefines an
identifier without redeclaring its type. For example, with this change,
if I redefine string-split with a different signature, csc will produce
inaccurate scrutiny warnings because calls to *my* string-split won't
match core's but it'll still have a declared-type, now. I haven't dug
into this too deeply yet (I'm hoping to take a crack at these issues
over the holidays) but I do think we'll have to make a call about what's
correct in this and similar situations.
Description: PGP signature
- Re: [Chicken-hackers] [PATCH] Fix (restore?) specializations from types.db when compiling core itself,
Evan Hanson <=