[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] A few fixes and improvements for -deploy mode

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] A few fixes and improvements for -deploy mode and csc.scm
Date: Sat, 16 Jan 2016 17:22:28 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hi all,

Attached is a set of patches that together fix #1106.

While working on the fix, I decided it would be useful to add support
for -prefix to chicken-uninstall and chicken-status.  I also ran into
the problem that csc's -deploy mode was broken again!  This happened
with our fix for the nasty issue where slashes and backslashes got
mixed up (the problem leading to CVE-2015-8235, if you recall).

Weirdly enough, that fix changed csc.scm, but only in master, not in
chicken-5!  Compare edd4926 with 5920000; I don't completely understand
the reasons why all those things were touched in csc.scm.
I tested it on Linux, it gave me an error:

$ ~/chickens/master/bin/csc -deploy foo.scm
cp: cannot stat ‘'/home/sjamaan/chickens/master/lib'/’: No such 
file or directory

Error: shell command terminated with non-zero exit status 256: cp 
''\''/home/sjamaan/chickens/master/lib'\''/' 'foo'

As you can see, it quote-wrapped the library prefix before appending
the library name to it, and then quote-wrapped the result once again.
This isn't picked up by our deploy tests because we don't use csc in
the tests.  I don't fully grok how ends up in the rev-app
directory, either.

And last but not least, I found that the CHICKEN 5 csc raised an
exception "unbound variable: create-directory"; which is of course
because that's from posix and we don't include the posix module there.
We should probably turn all the remaining programs into module-wrapped
ones, as well, to prevent such bugs in the future.  But that's a
different patch set, I think.


Attachment: 0001-Add-posix-to-declared-units-in-csc.scm.master.patch
Description: Text Data

Attachment: 0002-Fix-double-quote-wrapping-of-libs-in-csc.master.patch
Description: Text Data

Attachment: 0003-Add-prefix-support-to-chicken-uninstall-status.master.patch
Description: Text Data

Attachment: 0004-Do-not-reinstall-satisfied-deps-in-deploy-mode.master.patch
Description: Text Data

Attachment: 0001-Fix-dependencies-of-csc.scm.chicken-5.patch
Description: Text Data

Attachment: 0002-Add-prefix-support-to-chicken-uninstall-status.chicken-5.patch
Description: Text Data

Attachment: 0003-Do-not-reinstall-satisfied-deps-in-deploy-mode.chicken-5.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]