[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] on ticket 1231

From: Jörg F . Wittenberger
Subject: Re: [Chicken-hackers] on ticket 1231
Date: Tue, 26 Jan 2016 12:03:26 +0100
User-agent: Mozilla/5.0 (X11; Linux armv7l; rv:38.0) Gecko/20100101 Icedove/38.4.0

Hi all,

while this patch does fix two bugs in the old code, it introduces a new one.

I'm in the middle of expanding the test case and will soon post a new
patch.  (The difference to the patch I attached to ticket 1231 is only
one line - iff I don't find more.)

To make it easier for the reviewers to grok the code, I'll put more
comments into the test case.

For the curious attached my current version of the test.



Am 23.01.2016 um 13:19 schrieb Peter Bex:
> On Fri, Jan 22, 2016 at 07:42:09PM +0100, Jörg F. Wittenberger wrote:
>> Hi all,
>> there is a problem I have with ticket 1231.
>> In short: I'd love to see the patch applied.  (Or learn about issues it
>> causes.)
> I hadn't forgotten about the patch, I just didn't get around to it yet,
> and to be honest, I don't really grok this part of the code.
> The patch looks good as far as I can see (but like I said, I don't 100%
> grok this code), and I really like the test case, which is clean and
> simple.  The test case is what boosted my confidence in it, so I've went
> ahead and signed it off (with a slight reformatting and rewording of the
> commit message, and an update to NEWS).  I've attached it.
> Whoever pushes this, please also apply this to the CHICKEN 5 srfi-18 egg.
> Cheers,
> Peter

Attachment: mutex-test.scm
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]