[Chicken-hackers] Saver a patch: Re: Release blocker? Stack checks completely FUBAR? Or am I just paranoid?

[Jörg F . Wittenberger]

Hi,

the patch I sent is harmful.  I forgot to reset chicken.h to "backward
compatible".

Attached a better version.

After patching, recompile to get a csc using the new macros.  Then
change the first line in chicken.h to
#define USE_OLD_AV 0

recompile now.

Modify the second line to
#define USE_FIXED_DFLT ( !USE_OLD_AV && 0)
that is - change to 1 to 0 - if you want to try length-prefixed
argvector (I hope this still works).

Cheers

/Jörg

Am 28.02.2016 um 15:39 schrieb Jörg F. Wittenberger:
> Am 28.02.2016 um 15:19 schrieb Jörg F. Wittenberger:
>> BTW: currently a make check completed here.  This one re-uses a single,
>> stack allocated argvector of TEMPORARY_STACK_SIZE whenever the current
>> code would do C_alloc or av2[N].  Notable exception C_context_switch.
>> Interestingly: while this is the simplest code one could use, the length
>> tagged argvector is consistently about 2% faster here on all tests so far.
> 
> Attached the diff from my build tree to master.
> 
> This obviously needs cleanup.
> 
> But there needs to be a decision.  Do we want simpler code at the
> expense of 2-5% runtime?  Or do we want the length tagged version
> eventually?

av.diff
Description: Text Data