Re: [Chicken-hackers] [PATCH] Use begin to insert C_DEBUG_GLOBAL_ASSIGN events

[Peter Bex]

On Mon, Mar 07, 2016 at 04:56:22PM +1300, Evan Hanson wrote:
> On 2016-03-05 13:46, Peter Bex wrote:
> The ASSIGN event does, but the ENTRY event of an assigned procedure
> doesn't. The let binding changes the "dest" of the value expression, and
> that destination is what's used to name the ENTRY event when walking a
> lambda, so you end up with an ASSIGN event for "foo" but an ENTRY event
> for something like "g6".

Ah, I missed that bit.

> > Doesn't this change the semantics by emitting a debug event _before_
> > the value is calculated?'
> 
> It does. I hadn't considered that too important since I can see the
> logic in either ordering, but if the current behaviour is preferred then
> I think something as simple as the attached patch ought to be enough,
> instead.

That's better I think, I've pushed this version.

Cheers,
Peter

signature.asc
Description: Digital signature