Re: [Chicken-hackers] [PATCH] [PRERELEASE] Fix #1285

[Evan Hanson]

Hi Peter,

Thanks for looking into this. Your patch looks good as a fix for the
parameter restoration problem, but we also need to return the new value
from these fake parameters when they're called with arguments, even when
`set?` is false. Otherwise, the conversion step in the before thunk will
receive the original value to use as the new one, making the
parameterize a noop.

Attached is a supplemental patch (0002) that does this. I also went
through the project looking for other procedures that are documented as
parameters but aren't really, and the only one I could find was
`repository-path` so I've also included a patch (0003) that makes this a
true parameter object.

The final patch (0001) is just a signoff for yours, which I'm happy to
be applied with the others.

Cheers,

Evan

0001-Make-special-cased-parameter-setters-compatible-with.master.patch
Description: Text Data

0002-Make-special-cased-parameters-return-the-new-value.master.patch
Description: Text Data

0003-Make-repository-path-a-proper-parameter.master.patch
Description: Text Data

0001-Make-special-cased-parameter-setters-compatible-with.chicken-5.patch
Description: Text Data

0002-Make-special-cased-parameters-return-the-new-value.chicken-5.patch
Description: Text Data

0003-Make-repository-path-a-proper-parameter.chicken-5.patch
Description: Text Data

signature.asc
Description: PGP signature