[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH][5] Add `include-relative` form to "chicken

From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH][5] Add `include-relative` form to "chicken" module
Date: Tue, 9 Aug 2016 20:00:26 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Aug 09, 2016 at 11:55:38PM +1200, Evan Hanson wrote:
> Hi Peter,
> On 2016-07-16 20:11, Peter Bex wrote:
> > An include-relative is defined by the s48-modules egg.  I think it
> > makes more sense to have that, especially considering we also have
> > load-relative.
> Fair enough, here's a version that does that instead. For consistency
> I've tried to make `include-relative` behave as much like
> `load-relative` as possible. For example, when used from within a file
> it will include, erm, relatively, and when used from a non-file context
> (e.g. from a csi session) it will behave as though the "current file" is
> in the working directory.

Very nice!  I've pushed this.

> It also inherits a small problem with `load-relative` that I noticed
> while working on the patch, which is that only paths beginning with
> slashes are considered absolute, not paths beginning with drive letters
> when on Windows. It might be worth fixing this in a later changeset.

Yeah, Windows needs some more attention; people have been complaining
that the installation breaks in some way or other.  I should get a fresh
VM from modern-ie once more... *sigh*


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]