Re: [Chicken-hackers] [PATCH] Improve read/write invariance of keywords (#1332)

[Peter Bex]

On Fri, Nov 04, 2016 at 06:08:47PM +0100, address@hidden wrote:
> > Hi all,
> >
> > I've taken a look at #1332.  Attached are patches against master and
> > CHICKEN 5 to fix keyword handling.
> 
> I would propose to change this only in 5, since this might break things (as
> you hint at below).

Yeah, better safe than sorry.  Attached is a rework of the patch which
doesn't change the output style of keywords for master.  This patch is
also arguably much less nasty because it doesn't rearrange the original
code and factors out the writing decision of the symbols themselves into
a helper procedure.

The patch for CHICKEN 5 is split up in 2, the first is simply the master
patch, the second changes the behaviour to force "portable" style when
writing.

> > To avoid all these issues, I think it's simplest to just ignore the
> > keyword style and _always_ write keywords using the "portable" notation.
> 
> I would propose only doing so in "readable" printout (i.e. "wriite", but not
> "display").

I agree, this is more readable for humans (no pun intended).  This new
patch now does this only for CHICKEN 5, and only for "write".

Cheers,
Peter

0001-Improve-read-write-invariance-of-keywords-1332.chicken-5.patch
Description: Text Data

0001-Improve-read-write-invariance-of-keywords-1332.master.patch
Description: Text Data

0002-Use-portable-keyword-style-when-WRITEing.chicken-5.patch
Description: Text Data

signature.asc
Description: Digital signature