[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Ensure chicken-install honors -prefix when
felix . winkelmann
Re: [Chicken-hackers] [PATCH] Ensure chicken-install honors -prefix when using -keep-installed (#1144)
Sun, 01 Jan 2017 00:59:51 +0100
> Hi all,
> Attached is a pretty straightforward patch to fix #1144.
> The problem is that we're using "extension-information"
> while walking the egg list to see which eggs already exist.
> If extension-information returns a non-#f value, it will
> be removed from the list.
> When using -prefix, extension-information will still look
> in the system-wide directory. Instead, we had already copied
> the body of extension-information into "ext-version" so we
> can determine the version of an egg under the prefix. This
> patch simply re-uses that procedure to determine if the egg
> exists under the installation directory.
> I've done the following tests:
> - Installing the egg in the prefix with -keep-installed while it's
> not installed. It's installed.
> - Installing the egg in the prefix with -keep-installed while it
> was already installed. It's not installed.
> - Installing the egg system-wide, then running chicken-install
> with -keep-installed under a prefix. It's installed.
Since the egg-installation changed considerably in C5, I suggest to apply the
patch only in C4. I'm very much for dropping -prefix (and CHICKEN_PREFIX and
the likes) completely.