Re: [Chicken-hackers] [PATCH 0/1] Add _XOPEN_SOURCE feature test macro

[Evan Hanson]

Hi guys,

Thanks for looking at the patches.

I've pushed a modified version of Peter's fix for time on Cygwin, since
that's clearly an improvement over relying on `command'. (We can't use
"true" in time's place, however, or the tests it's timing won't actually
be run since true totally ignores its arguments.) The issue of command
visibility is interesting as apparently calling a command directly vs.
through a variable is significant w.r.t. whether or not the built-in
kicks in. Anyway, I've tested the current approach on Cygwin, MSYS2,
Linux, and OpenBSD, and it seems to work on all of these systems so I'd
say we're probably good.

Regarding the new warnings you're seeing, Peter, unfortunately I can't
reproduce them. I've now tried all three combinations of Cygwin and
Windows 7 (32 vs. 64-bit), and the _XOPEN_SOURCE declaration seems to
work fine as-is on all of them for me. The x86 box I used was from
modern.ie, too, which AIUI is what you're using as well(?), so I'm at a
bit of a loss. Are you using the setup-x86.exe Cygwin installers from
cygwin.com?

Evan

signature.asc
Description: PGP signature