[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Move some low-hanging fruit from posix.scm
|
From: |
Peter Bex |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Move some low-hanging fruit from posix.scm to file.scm |
|
Date: |
Sun, 2 Jul 2017 19:38:52 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sun, Jul 02, 2017 at 12:20:45PM +1200, Evan Hanson wrote:
> I think it should stay in irregex. Glob patterns are generally useful,
> and the procedure actually returns a regexp or SRE, so making it part of
> the library that deals with those data types makes sense to me.
>
> In fact, if we're going to expose it, I think it would be best to drop
> the flag that changes its return type and make the procedure *always*
> return an SRE. This is more flexible, matches the existing conversion
> procedures like "string->sre" nicely, and the other behaviour is just
> one `irregex` call away. Here's a patch that does this, let me know what
> you think.
Excellent, I've pushed this.
BTW, I did notice a small but annoying problem: When I ran "make check",
I got an error on test-glob.scm that glob->sre wasn't defined. Turns out
that there is still an issue with csi and library loading; after
"make install" the tests ran fine, so it was due to the irregex library
being loaded from the installed location rather than the source dir.
I'm not quite sure how to fix that.
Cheers,
Peter
signature.asc
Description: PGP signature