chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix the inconsistent behavior between valu


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Fix the inconsistent behavior between values and call/cc
Date: Tue, 12 Sep 2017 21:04:36 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Sep 08, 2017 at 01:46:14AM +0200, Kooda wrote:
> Hi!
> 
> Here is a patch and a test case for the #1390 ticket.
> 
> I’m not too sure about the quality and implications of this patch, please 
> review
> it thoroughly. :)

Thanks a lot!  Especially the tests are nice and concise.

Nevertheless, to be absolutely thorough, I've added another
test to ensure that we don't bail out when the argument count
is correct.  I've also added a note to NEWS (it's a relatively
important user-visible change) and added the new test file to
the distribution manifest.  Finally, I've also renamed
call_cc_values_wrapper() to call_cc_wrapper(), removing the old
one, because of the two functions, only one was still being used.

Cheers,
Peter

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]