[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] [5] Avoid storing threads in trace-buffer

From: Jörg F . Wittenberger
Subject: Re: [Chicken-hackers] [PATCH] [5] Avoid storing threads in trace-buffer
Date: 04 Nov 2017 20:06:59 +0100

Just wondering. If memory usage was the concern, why not simple compile without tracing?

This way we pay one more slot per thread. Plus some lookup. What do we earn?

Maybe I'm missing something?


On Sat, Oct 28, 2017 at 09:01:15PM +0200, address@hidden wrote:
This is intended to fix #1356: threads may be retained too long in the trace buffer, because some sort of method is required to extract the call chain for a specific thread (multiple threads can create entries in the trace buffer and thus must be distinguished).

Now a thread has an additional slot with a unique ID, which is stored in the trace buffer instead of the thread itself. Peter suggested a gensym, but this patch uses a pair, which is (slightly) cheaper and doesn't bump the gensym counter.

Looks good to me, pushed!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]