[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Enable using import in static binaries

From: Evan Hanson
Subject: Re: [Chicken-hackers] [PATCH] Enable using import in static binaries
Date: Mon, 15 Jan 2018 22:39:28 +1300

Hey there,

This is great work, thanks Felix. It's a big patch and must have taken some
time to work through, so thank you for that.

There are just two small things I'd like to tweak:

1. Make it so we don't automatically add the eval-modules unit when the
   "-raw" or "-explicit-use" flag is given used (the user should
   explicitly use these in this case, as with any other unit).
2. Make eval-modules use the modules unit, since that must be loaded
   first so that this new `##sys#import-library-hook' is defined before
   it is redefined.

If you're OK with these then I'm happy make those changes and push



reply via email to

[Prev in Thread] Current Thread [Next in Thread]