[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Enable using import in static binaries
From: |
felix . winkelmann |
Subject: |
Re: [Chicken-hackers] [PATCH] Enable using import in static binaries |
Date: |
Mon, 15 Jan 2018 12:08:01 +0100 |
> Hey there,
>
> This is great work, thanks Felix. It's a big patch and must have taken some
> time to work through, so thank you for that.
>
> There are just two small things I'd like to tweak:
>
> 1. Make it so we don't automatically add the eval-modules unit when the
> "-raw" or "-explicit-use" flag is given used (the user should
> explicitly use these in this case, as with any other unit).
Sure, that makes perfect sense.
> 2. Make eval-modules use the modules unit, since that must be loaded
> first so that this new `##sys#import-library-hook' is defined before
> it is redefined.
Ah, ok. Sorry about that.
I also forgot to add eval-modules.c to distribution/manifest. If you could
add that, I'd be grateful.
>
> If you're OK with these then I'm happy make those changes and push
> everything.
Sure, thanks a lot!
felix