chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Make chicken-install work when the egg fil


From: felix . winkelmann
Subject: Re: [Chicken-hackers] [PATCH] Make chicken-install work when the egg file is inside a chicken/ subdirectory.
Date: Mon, 15 Jan 2018 14:03:40 +0100

> Woops, send it a bit too fast without writing any context.
>
> I remembered this feature of being able to put the .egg file into a
> chicken/ subdirectory, but it doesn’t seem to be working.
>
> This is the smallest patch I could come up with, but it’s rather ugly.
>
> Doing it a proper way would require changing the internal list of eggs
> structure of chicken-install and I did not dare to do that, as I’m not
> very familiar with the code.

You are right that this feature doesn't seem to work. The intention is mainly
to be able to run "chicken-install" without any arguments in a development
tree and have it pick up a chicken/*.egg automatically, if it exists. Once
cached, the egg file could be placed in the toplevel directory and processed
as normal. The feature was requested to avoid cluttering the toplevel directory
of a repository with implementation specific files and thus have the chicken-
specific setup information in a subdirectory called "chicken".

I'm not sure about your patch: eval.scm actually doesn't use 
egg-information.scm,
so it is correct to remove the dependency in rules.make. On the other hand,
you add the include-statement for the (unneeded) file. Fixing load-egg-info is
basically the right thing to do, though, and the current handling in 
perform-actions
(chicken-install.scm) may not be effective. Please let me investigate this a bit
and I'll get back to you about this.


felix




reply via email to

[Prev in Thread] Current Thread [Next in Thread]